Skip to content

Add true/false as primitive types #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

Add true/false as primitive types #1582

merged 1 commit into from
Dec 19, 2024

Conversation

@bobvandevijver
Copy link
Contributor

@bobvandevijver bobvandevijver commented Dec 19, 2024

Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

The new union handler does not consider false or true as a primitive type, causing my array|false with an array value to be serialised as true.

@bobvandevijver bobvandevijver marked this pull request as draft December 19, 2024 09:48
@bobvandevijver bobvandevijver marked this pull request as ready for review December 19, 2024 10:06
@bobvandevijver bobvandevijver mentioned this pull request Dec 19, 2024
Closed
bobvandevijver added a commit to utwente/living-textbook that referenced this pull request Dec 19, 2024
@bobvandevijver
Revert to previous serializer, current one is broken.
42515e5 
See
  - schmittjoh/serializer#1573
  - schmittjoh/serializer#1576
  - schmittjoh/serializer#1575
  - schmittjoh/serializer#1582
@scyzoryck
Copy link
Collaborator

scyzoryck commented Dec 19, 2024

Good catch! Thanks!

@scyzoryck scyzoryck merged commit f974e58 into schmittjoh:master Dec 19, 2024
20 checks passed
@scyzoryck scyzoryck added the Union Types Support for Union Types label Dec 19, 2024
@bobvandevijver bobvandevijver deleted the patch-1 branch January 15, 2025 10:38
@bobvandevijver
Copy link
Contributor Author

bobvandevijver commented Jan 16, 2025

@scyzoryck Any sight on a release containing this change?

@scyzoryck
Copy link
Collaborator

scyzoryck commented Jan 16, 2025

@bobvandevijver - released! Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Union Types Support for Union Types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobvandevijver @scyzoryck