Inject an attribute metadata driver into the DoctrineDriver when testing #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scyzoryck
approved these changes
Oct 19, 2023
Collaborator
scyzoryck
left a comment
scyzoryck
left a comment
There was a problem hiding this comment.
Looks good for me! I will merge it on the beginning of the next week with other related PRs. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small test change that will help with the ORM 3.0 compat. Without its classes having the
@Annotationannotation anymore in 3.0, there are a lot ofDoctrine\Common\Annotations\AnnotationException: [Semantical Error] The class "Doctrine\ORM\Mapping\Entity" is not annotated with @Annotation.style exceptions being thrown. Changing theDoctrineDriverTestto have version conditional behavior and use an annotation or attribute driver as appropriate clears out some of those.Merging #1471 will help address this in other places in the tests at a later point, but with the hard dependency still in place, those other test classes are not yet updated.