Skip to content

Conversation

@klmkyo
Copy link
Contributor

@klmkyo klmkyo commented Apr 17, 2024

Fixes a bug where ReceiveDialog text contents are empty when loading another request from the queue.

Before:

2024-04-17_12-07-43_863_chrome.mp4

After:

2024-04-17_12-08-12_976_chrome.mp4

From my understanding, _dequeueRequests already handles the possibility of there not being any messages in the queue in here:

    _dequeueRequests() {
        if (!this._receiveTextQueue.length) {
            this.$text.innerHTML = "";
            return;
        }

The line removed in this PR always clears the innerHTML, regardless of if there are any messages in the queue, which leads to $text being empty when viewing next message from the queue.

@schlagmichdoch
Copy link
Owner

Hey @klmkyo,
Thanks for contributing!

Not sure how this got into production.

I think the clearing should be done in the hide method though so I will change your code a bit before merging.

@schlagmichdoch
Copy link
Owner

I fixed this with 35f47d9 and added you as Co-author which should add you to the contributors of this project

schlagmichdoch added a commit that referenced this pull request Apr 18, 2024
## Fixes
- Received message empty when loaded from queue (#288)

## Languages
- New Language Hungarian
- New Language Polish
- New Language Traditional Chinese
- Translations update from Hosted Weblate (Portuguese (Brazil), Russian, Japanese, Arabic, Indonesian, Dutch, French)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants