Skip to content

fix TURN/TURNS#106

Open
xundeenergie wants to merge 15 commits into
schlagmichdoch:masterfrom
xundeenergie:master
Open

fix TURN/TURNS#106
xundeenergie wants to merge 15 commits into
schlagmichdoch:masterfrom
xundeenergie:master

Conversation

@xundeenergie
Copy link
Copy Markdown
Contributor

@xundeenergie xundeenergie commented Apr 22, 2023 •
edited
Loading

fix TURN/STURN
61b5260 
* remove docker-compose-coturn.yml and replace it with and example-file,
because there are user-data inside, which should not be on git
* add a whole rtc_config_example-coturn.json to be copied to
  rtc_config.json and only the domain <DOMAIN> should be changed.
* modified the documentation
* modified the .gitignore to ignore the files with user-data
@xundeenergie xundeenergie changed the title fix TURN/STURN fix TURN/TURNS Apr 22, 2023
@xundeenergie xundeenergie mentioned this pull request Apr 22, 2023
Closed
schlagmichdoch
schlagmichdoch requested changes Apr 23, 2023
View reviewed changes
Copy link
Copy Markdown
Owner

@schlagmichdoch schlagmichdoch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR! I had just some small change requests. Also, some your commits appear to be authored with your real name. If you don't want it to appear in the contributors list you might rebase your commit before merging.

Comment thread turnserver_example.conf Outdated
Comment thread docs/host-your-own.md Outdated
Comment thread docs/host-your-own.md
Comment thread docker-compose-coturn.yml Outdated
Comment thread .gitignore Outdated
@xundeenergie
Copy link
Copy Markdown
Contributor Author

xundeenergie commented Apr 23, 2023 •
edited
Loading

I've just seen... with working TLS for turns and stuns i can see also over the internet every user, which is on pairdrop.schuerz.at. Like we are in the same LAN...

But i don't know, what the real reason is for this new behaviour...

Is this, how it should work? It thought, only if devices are paired, you can see each other...

@xundeenergie
Copy link
Copy Markdown
Contributor Author

xundeenergie commented Apr 24, 2023

Now i reverted all this trials to server coturn also on port 443 and changed it to port 5349 for tls-secured connections.
Now it should work as easy as possible to run coturn for pairdrop configured and ssl-secured with turns and stuns almost out of the box.

@xundeenergie
Copy link
Copy Markdown
Contributor Author

xundeenergie commented Apr 25, 2023

It is strange... i csn not connect with one collegue.

Not on mobile-internet, not on cable-internet.

With my other collegues it's working.
It worked on port 443... and thrrefore i need an extra compiled nginx module...

@schlagmichdoch schlagmichdoch mentioned this pull request Jun 23, 2023
Closed
schlagmichdoch added a commit that referenced this pull request Oct 28, 2023
@schlagmichdoch
- add guide to documentation and example files to repository to run c…
0a5a70e 
…oturn alongside PairDrop via Docker Compose

- enable TURN over TLS
- modified the .gitignore to ignore files with user-data
- should fix #105
- partly cherry-picked from #106

Co-authored-by: xundeenergie <xundeenergie@@users.noreply.github.com>
schlagmichdoch added a commit that referenced this pull request Oct 28, 2023
@schlagmichdoch @xundeenergie
- add guide to documentation and example files to repository to run c…
2467a5f 
…oturn alongside PairDrop via Docker Compose

- enable TURN over TLS
- modified the .gitignore to ignore files with user-data
- should fix #105
- partly cherry-picked from #106

Co-authored-by: xundeenergie <xundeenergie@users.noreply.github.com>
schlagmichdoch added a commit that referenced this pull request Oct 28, 2023
@schlagmichdoch @xundeenergie
- add guide to documentation and example files to repository to run c…
1c79290 
…oturn alongside PairDrop via Docker Compose

- enable TURN over TLS
- modified the .gitignore to ignore files with user-data
- should fix #105
- partly cherry-picked from #106

Co-authored-by: xundeenergie <xundeenergie@users.noreply.github.com>
@schlagmichdoch schlagmichdoch mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlagmichdoch schlagmichdoch schlagmichdoch requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TURN/TURNS in docker-compose is not working correctly Bug: Paired devices are not showing unless on same network

2 participants

@xundeenergie @schlagmichdoch