Skip to content

Fix #247: Use borrowed &str keys for existing_tx_map in process_wallet_transactions #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schjonhaug merged 1 commit into from
Mar 13, 2026
Merged

Fix #247: Use borrowed &str keys for existing_tx_map in process_wallet_transactions #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions backend/src/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,11 +412,11 @@ impl WalletSyncService {

// Create HashMap for O(1) transaction lookups to avoid individual database queries
let existing_tx_map: std::collections::HashMap<
String,
&str,
&crate::metadata::TransactionWithWallet,
> = existing_transactions
.iter()
.map(|tx| (tx.txid.clone(), tx))
.map(|tx| (tx.txid.as_str(), tx))
.collect();

// Sort existing transactions by first_seen_at ASC (oldest first) for proper balance calculation
Expand Down Expand Up @@ -448,7 +448,7 @@ impl WalletSyncService {

// Preserve existing timestamp if transaction already exists, otherwise use current time
let first_seen_at = existing_tx_map
.get(&txid)
.get(txid.as_str())
.map(|tx| tx.first_seen_at)
.unwrap_or_else(|| {
std::time::SystemTime::now()
Expand Down Expand Up @@ -489,7 +489,7 @@ impl WalletSyncService {
) = tx_data;

// Check if this is an existing transaction
let existing_tx = existing_tx_map.get(txid).copied();
let existing_tx = existing_tx_map.get(txid.as_str()).copied();

if let Some(existing) = existing_tx {
// Existing transaction - check if it's transitioning from pending to confirmed
Expand Down Expand Up @@ -612,7 +612,7 @@ impl WalletSyncService {
&all_transactions
{
// Check if we already know about this transaction using in-memory lookup
let existing_tx = existing_tx_map.get(txid);
let existing_tx = existing_tx_map.get(txid.as_str());

match existing_tx {
None => {
Expand Down Expand Up @@ -732,7 +732,7 @@ impl WalletSyncService {
for conflicted_txid in &conflicted_txids {
let conflicted_txid_str = conflicted_txid.to_string();
// Check if this conflicted transaction is in our pending transactions using in-memory lookup
if let Some(pending_tx) = existing_tx_map.get(&conflicted_txid_str) {
if let Some(pending_tx) = existing_tx_map.get(conflicted_txid_str.as_str()) {
if pending_tx.transaction_status == "pending" {
// Find the conflicted transaction's inputs
let conflicted_tx_inputs: Option<Vec<_>> = bdk_tx_map
Expand Down
Loading