-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Problem
In scripts/dev.sh, the importdescriptors RPC call result is piped to /dev/null without checking the success flags in the response. If the import fails, the script still declares the wallet "seeded" and proceeds to fund it.
Impact
If descriptor import fails silently, subsequent runs may keep sending funds to an address while the wallet can't track or spend them. This could lead to confusing development states.
Suggested Fix
Capture the importdescriptors response, check that all entries have "success": true, and fail fast if any import fails.
This pattern applies to all wallet creation calls in dev.sh, not just the new satoshi-genesis wallet.
Context
Flagged during code review of #234.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels