Skip to content

dev.sh: importdescriptors result is ignored silently #235

@schjonhaug

Description

@schjonhaug

Problem

In scripts/dev.sh, the importdescriptors RPC call result is piped to /dev/null without checking the success flags in the response. If the import fails, the script still declares the wallet "seeded" and proceeds to fund it.

Impact

If descriptor import fails silently, subsequent runs may keep sending funds to an address while the wallet can't track or spend them. This could lead to confusing development states.

Suggested Fix

Capture the importdescriptors response, check that all entries have "success": true, and fail fast if any import fails.

This pattern applies to all wallet creation calls in dev.sh, not just the new satoshi-genesis wallet.

Context

Flagged during code review of #234.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions