Allow multiple firewalls#285
Conversation
|
True, I'm wondering why no one has discovered this issue before. Probably everyone is just using it with a single firewall. For whatever reason the build result from Travis-CI didn't show up here, so I just restarted it to make the results show up. There are some code style issues that I'd like to ask you to fix. Furthermore, would you please update the default for template to make use of these two new variables. Overall, the PR looks well executed, so after you did these two changes I can accept that and release a patched version :) |
|
Yeah, I was quite confused as well. I'll get the sample template fixed today. What are the style changes you wanted? |
|
The style issues are listed there in the build log: https://travis-ci.org/github/scheb/two-factor-bundle/jobs/679146572 Thanks! |
Perhaps I'm not doing this correctly however, we need 2fa with multiple firewalls. There seems to be an issue with being able to support that. The provider is configured with the template to render, however the path is configured by the firewall. So when my email provider renders the 2fa it has no concept of where the check should be submitted to. If the template was configured on the firewall that'd be different. So what I've done is passed the check_path variable to the template so the form submission can submit to the correct location
|
Hello @scheb just a gentle ping in case you didn't see the updated PR. If you are busy no worries, I just wasn't sure if you were notified of the update. |
|
Indeed, I didn't see it, didn't get a notification. Will have a look tomorrow. |
|
Released as v4.15.0. Thank you for your contribution! |
2 participants
Perhaps I'm not doing this correctly however, we need 2fa with multiple firewalls. There seems to be an issue with being able to support that.
The provider is configured with the template to render, however the path is configured by the firewall. So when my email provider renders the 2fa it has no concept of where the check should be submitted to. If the template was configured on the firewall that'd be different. So what I've done is passed the check_path variable to the template so the form submission can submit to the correct location