Skip to content

feat(container): add support for API v1#3964

Draft
Mia-Cross wants to merge 1 commit intoscaleway:mainfrom
Mia-Cross:container_migration_v1
Draft

feat(container): add support for API v1#3964
Mia-Cross wants to merge 1 commit intoscaleway:mainfrom
Mia-Cross:container_migration_v1

Conversation

@Mia-Cross
Copy link
Copy Markdown
Contributor

@Mia-Cross Mia-Cross commented Apr 29, 2026

This PR integrates the new API v1 for Serverless Containers in Terraform.

  1. Changes on scaleway_container resource:
  • New field: startup_probe allows to define how to check if the container has started successfully.
  • registry_image is deprecated in favor of image.
  • memory_limit (measured in MiB) is deprecated in favor of memory_limit_bytes (measured in bytes)
  • local_storage_limit (measured in MiB) is deprecated in favor local_storage_limit_bytes (measured in bytes)
  • domain_name computed attribute is deprecated in favor of public_endpoint
  • health_check is deprecated in favor of liveness_probe
  • http_option is deprecated in favor of https_connections_only
  • deploy is deprecated and no longer has any effect, containers are automatically deployed at creation, and redeployed following any change.
  1. Changes on scaleway_container_token resource:

This resource is deprecated, please use IAM tokens instead (refer to the documentation to see how to implement them)

  1. Changes on scaleway_container_cron resource:

This resource is deprecated, please use the scaleway_container_trigger.cron resource instead

  1. Changes on scaleway_container_trigger resource:
  • New trigger type: cron
  • On NATS triggers, credentials are no longer automatically generated, they have to be passed using the credentials_file_content field (refer to the documentation for more info)
  • On SQS triggers, credentials are no longer automatically generated, they have to be passed using the access_key and secret_key fields (refer to the documentation for more info)

TODO:

  • Update documentation
  • Container: fix TODO on image update + test

Closes #3965

@Mia-Cross Mia-Cross self-assigned this Apr 29, 2026
@Mia-Cross Mia-Cross added enhancement container Container issues, bugs and feature requests priority:high New features labels Apr 29, 2026
@Mia-Cross Mia-Cross force-pushed the container_migration_v1 branch from b91af87 to 6764901 Compare May 4, 2026 19:21
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 5, 2026

Codecov Report

❌ Patch coverage is 0% with 643 lines in your changes missing coverage. Please review.
✅ Project coverage is 2.17%. Comparing base (db9f87a) to head (d45fa55).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/services/container/helpers_container.go 0.00% 293 Missing ⚠️
internal/services/container/container.go 0.00% 158 Missing ⚠️
...l/services/container/helpers_container_triggers.go 0.00% 140 Missing ⚠️
internal/services/container/cron.go 0.00% 37 Missing ⚠️
internal/services/container/namespace.go 0.00% 11 Missing ⚠️
internal/services/container/domain.go 0.00% 3 Missing ⚠️
...ternal/services/container/container_data_source.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3964      +/-   ##
========================================
- Coverage   2.21%   2.17%   -0.04%     
========================================
  Files        525     525              
  Lines      56959   57396     +437     
========================================
- Hits        1260    1248      -12     
- Misses     55599   56048     +449     
  Partials     100     100              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross force-pushed the container_migration_v1 branch from 42c1405 to 56eb1ca Compare May 5, 2026 19:35
@github-actions github-actions Bot added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label May 5, 2026
@Mia-Cross Mia-Cross force-pushed the container_migration_v1 branch from 56eb1ca to 4ccafb6 Compare May 5, 2026 19:37
@Mia-Cross Mia-Cross force-pushed the container_migration_v1 branch from 4ccafb6 to d45fa55 Compare May 5, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

container Container issues, bugs and feature requests enhancement priority:high New features vpc Virtual Private Cloud (VPC) issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate container resources to API v1

2 participants