fix(provider): fix framework provider meta for all various config sources#3728
Merged
fix(provider): fix framework provider meta for all various config sources#3728
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3728 +/- ##
=====================================
Coverage 2.31% 2.31%
=====================================
Files 471 471
Lines 51669 51750 +81
=====================================
+ Hits 1196 1199 +3
- Misses 50381 50460 +79
+ Partials 92 91 -1 ☔ View full report in Codecov by Sentry. |
75f5007 to
c41e5b2
Compare
fe970c7 to
6d6145a
Compare
remyleone
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3718
I tried to keep the sdkv2, framework provider, and meta logic cleanly delimitated, while remaining faithful to the initial sdkv2 implementation.
The sdkv2 config schema
schema.ResourceDatanow translates as a customFrameworkProviderConfigon Framework Provider side (which I had to leave in the provider package to prevent having silly circular imports, hence the slight implementation asymmetry between the two providers).