Skip to content

fix(provider): fix framework provider meta for all various config sources#3728

Merged
remyleone merged 8 commits intomainfrom
fix/framework-provider-meta
Mar 3, 2026
Merged

fix(provider): fix framework provider meta for all various config sources#3728
remyleone merged 8 commits intomainfrom
fix/framework-provider-meta

Conversation

@estellesoulard
Copy link
Contributor

@estellesoulard estellesoulard commented Feb 26, 2026

#3718

I tried to keep the sdkv2, framework provider, and meta logic cleanly delimitated, while remaining faithful to the initial sdkv2 implementation.
The sdkv2 config schema schema.ResourceData now translates as a custom FrameworkProviderConfig on Framework Provider side (which I had to leave in the provider package to prevent having silly circular imports, hence the slight implementation asymmetry between the two providers).

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 7.60870% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 2.31%. Comparing base (ce0b433) to head (5812fb8).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/meta/meta.go 12.06% 51 Missing ⚠️
provider/framework.go 0.00% 34 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3728   +/-   ##
=====================================
  Coverage   2.31%   2.31%           
=====================================
  Files        471     471           
  Lines      51669   51750   +81     
=====================================
+ Hits        1196    1199    +3     
- Misses     50381   50460   +79     
+ Partials      92      91    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@estellesoulard estellesoulard force-pushed the fix/framework-provider-meta branch from 75f5007 to c41e5b2 Compare February 26, 2026 16:36
@estellesoulard estellesoulard marked this pull request as ready for review February 26, 2026 17:05
@estellesoulard estellesoulard force-pushed the fix/framework-provider-meta branch from fe970c7 to 6d6145a Compare February 26, 2026 17:39
@remyleone remyleone deleted the branch main February 27, 2026 10:21
@remyleone remyleone closed this Feb 27, 2026
@estellesoulard estellesoulard changed the base branch from master to main February 27, 2026 10:26
@remyleone remyleone added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit ba301b7 Mar 3, 2026
88 checks passed
@remyleone remyleone deleted the fix/framework-provider-meta branch March 3, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants