Skip to content

chore: add a test to ensure that all resources got a data source#3663

Open
remyleone wants to merge 5 commits intoscaleway:mainfrom
remyleone:check_data_source
Open

chore: add a test to ensure that all resources got a data source#3663
remyleone wants to merge 5 commits intoscaleway:mainfrom
remyleone:check_data_source

Conversation

@remyleone
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings February 13, 2026 10:43
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 2.33%. Comparing base (a899229) to head (fb721b7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3663   +/-   ##
======================================
  Coverage    2.33%   2.33%           
======================================
  Files         453     453           
  Lines       49839   49839           
======================================
  Hits         1165    1165           
  Misses      48582   48582           
  Partials       92      92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a test to verify that all resources in the Scaleway Terraform provider have corresponding data sources, helping maintain consistency between resources and data sources in the provider.

Changes:

  • Added a new test function TestSDKProvider_DataSourceExistForEachDataSource that iterates through all resources and verifies a corresponding data source exists
  • Defined a comprehensive exception list of 64 resources that are allowed to not have corresponding data sources

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
yfodil
yfodil previously approved these changes Feb 13, 2026
estellesoulard
estellesoulard previously approved these changes Feb 13, 2026
@remyleone remyleone added this pull request to the merge queue Feb 17, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 17, 2026
* chore: add a test to ensure that all resources got a data source

* Update provider/sdkv2_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2026
@remyleone remyleone added this pull request to the merge queue Feb 17, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 17, 2026
@remyleone remyleone added this pull request to the merge queue Feb 18, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2026
@remyleone remyleone enabled auto-merge February 20, 2026 17:43
@remyleone remyleone deleted the branch scaleway:main February 27, 2026 10:20
@remyleone remyleone closed this Feb 27, 2026
auto-merge was automatically disabled February 27, 2026 10:20

Pull request was closed

@jremy42 jremy42 reopened this Feb 27, 2026
@jremy42 jremy42 changed the base branch from master to main February 27, 2026 10:31
@jremy42 jremy42 dismissed stale reviews from estellesoulard and yfodil February 27, 2026 10:31

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants