Skip to content

docs(lb): fix ACL match field description #2656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

docs(lb): fix ACL match field description #2656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions api/lb/v1/lb_sdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1629,7 +1629,7 @@ type Frontend struct {
// ConnectionRateLimit: rate limit for new connections established on this frontend. Use 0 value to disable, else value is connections per second.
ConnectionRateLimit *uint32 `json:"connection_rate_limit"`

// EnableAccessLogs: defines wether to enable access logs on the frontend.
// EnableAccessLogs: defines whether to enable access logs on the frontend.
EnableAccessLogs bool `json:"enable_access_logs"`
}

Expand Down Expand Up @@ -1740,7 +1740,7 @@ type ACL struct {
// Name: ACL name.
Name string `json:"name"`

// Match: ACL match filter object. One of `ip_subnet` or `http_filter` & `http_filter_value` are required.
// Match: ACL match filter object. One of `ip_subnet`, `ips_edge_services` or `http_filter` & `http_filter_value` are required.
Match *ACLMatch `json:"match"`

// Action: action to take when incoming traffic matches an ACL filter.
Expand Down Expand Up @@ -1844,7 +1844,7 @@ type ACLSpec struct {
// Action: action to take when incoming traffic matches an ACL filter.
Action *ACLAction `json:"action"`

// Match: ACL match filter object. One of `ip_subnet` or `http_filter` and `http_filter_value` are required.
// Match: ACL match filter object. One of `ip_subnet`, `ips_edge_services` or `http_filter` and `http_filter_value` are required.
Match *ACLMatch `json:"match"`

// Index: priority of this ACL (ACLs are applied in ascending order, 0 is the first ACL executed).
Expand Down Expand Up @@ -1907,7 +1907,7 @@ type CreateACLRequest struct {
// Action: action to take when incoming traffic matches an ACL filter.
Action *ACLAction `json:"action"`

// Match: ACL match filter object. One of `ip_subnet` or `http_filter` & `http_filter_value` are required.
// Match: ACL match filter object. One of `ip_subnet`, `ips_edge_services` or `http_filter` & `http_filter_value` are required.
Match *ACLMatch `json:"match,omitempty"`

// Index: priority of this ACL (ACLs are applied in ascending order, 0 is the first ACL executed).
Expand Down Expand Up @@ -2082,7 +2082,7 @@ type CreateFrontendRequest struct {
// ConnectionRateLimit: rate limit for new connections established on this frontend. Use 0 value to disable, else value is connections per second.
ConnectionRateLimit *uint32 `json:"connection_rate_limit,omitempty"`

// EnableAccessLogs: defines wether to enable access logs on the frontend.
// EnableAccessLogs: defines whether to enable access logs on the frontend.
EnableAccessLogs bool `json:"enable_access_logs"`
}

Expand Down Expand Up @@ -3040,7 +3040,7 @@ type UpdateACLRequest struct {
// Action: action to take when incoming traffic matches an ACL filter.
Action *ACLAction `json:"action"`

// Match: ACL match filter object. One of `ip_subnet` or `http_filter` & `http_filter_value` are required.
// Match: ACL match filter object. One of `ip_subnet`, `ips_edge_services` or `http_filter` & `http_filter_value` are required.
Match *ACLMatch `json:"match,omitempty"`

// Index: priority of this ACL (ACLs are applied in ascending order, 0 is the first ACL executed).
Expand Down Expand Up @@ -3201,7 +3201,7 @@ type UpdateFrontendRequest struct {
// ConnectionRateLimit: rate limit for new connections established on this frontend. Use 0 value to disable, else value is connections per second.
ConnectionRateLimit *uint32 `json:"connection_rate_limit,omitempty"`

// EnableAccessLogs: defines wether to enable access logs on the frontend.
// EnableAccessLogs: defines whether to enable access logs on the frontend.
EnableAccessLogs *bool `json:"enable_access_logs,omitempty"`
}

Expand Down Expand Up @@ -3448,7 +3448,7 @@ type ZonedAPICreateACLRequest struct {
// Action: action to take when incoming traffic matches an ACL filter.
Action *ACLAction `json:"action"`

// Match: ACL match filter object. One of `ip_subnet` or `http_filter` & `http_filter_value` are required.
// Match: ACL match filter object. One of `ip_subnet`, `ips_edge_services` or `http_filter` & `http_filter_value` are required.
Match *ACLMatch `json:"match,omitempty"`

// Index: priority of this ACL (ACLs are applied in ascending order, 0 is the first ACL executed).
Expand Down Expand Up @@ -3623,7 +3623,7 @@ type ZonedAPICreateFrontendRequest struct {
// ConnectionRateLimit: rate limit for new connections established on this frontend. Use 0 value to disable, else value is connections per second.
ConnectionRateLimit *uint32 `json:"connection_rate_limit,omitempty"`

// EnableAccessLogs: defines wether to enable access logs on the frontend.
// EnableAccessLogs: defines whether to enable access logs on the frontend.
EnableAccessLogs bool `json:"enable_access_logs"`
}

Expand Down Expand Up @@ -4251,7 +4251,7 @@ type ZonedAPIUpdateACLRequest struct {
// Action: action to take when incoming traffic matches an ACL filter.
Action *ACLAction `json:"action"`

// Match: ACL match filter object. One of `ip_subnet` or `http_filter` & `http_filter_value` are required.
// Match: ACL match filter object. One of `ip_subnet`, `ips_edge_services` or `http_filter` & `http_filter_value` are required.
Match *ACLMatch `json:"match,omitempty"`

// Index: priority of this ACL (ACLs are applied in ascending order, 0 is the first ACL executed).
Expand Down Expand Up @@ -4412,7 +4412,7 @@ type ZonedAPIUpdateFrontendRequest struct {
// ConnectionRateLimit: rate limit for new connections established on this frontend. Use 0 value to disable, else value is connections per second.
ConnectionRateLimit *uint32 `json:"connection_rate_limit,omitempty"`

// EnableAccessLogs: defines wether to enable access logs on the frontend.
// EnableAccessLogs: defines whether to enable access logs on the frontend.
EnableAccessLogs *bool `json:"enable_access_logs,omitempty"`
}

Expand Down
Loading