feat: remove global attach/detach mutex#69
Merged
Tomy2e merged 1 commit intoscaleway:masterfrom Sep 11, 2024
Merged
Conversation
nox-404
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should increase attach/detach performance.
The previous implementation was slow when multiple volumes are attached/detached simultaneously: we locked both the attach/detach API calls and the wait for the volume to be in a terminal state.
Only the attach/detach API calls should be locked (ideally per server). Fortunately, the SDK already implements a lock on Attach and Detach operations so it should not be needed to implement it again at CSI driver level.