Skip to content

feat(instance): add console command#897

Merged
jerome-quere merged 11 commits intoscaleway:v2from
Sh4d1:instance_console
May 1, 2020
Merged

feat(instance): add console command#897
jerome-quere merged 11 commits intoscaleway:v2from
Sh4d1:instance_console

Conversation

@Sh4d1
Copy link
Copy Markdown
Contributor

@Sh4d1 Sh4d1 commented Apr 22, 2020

No description provided.

@remyleone remyleone added the instance Instance issues, bugs and feature requests label Apr 25, 2020
Sh4d1 and others added 7 commits April 30, 2020 22:31
Signed-off-by: Patrik Cyvoct <[email protected]>
Signed-off-by: Patrik Cyvoct <[email protected]>
Signed-off-by: Patrik Cyvoct <[email protected]>
Comment thread internal/gotty/client.go
Comment thread internal/gotty/client.go Outdated
Comment thread internal/gotty/client.go Outdated
cnsChan, cnsErrChan := consoleReader(cns)

// Force first resize
resizeChan <- syscall.SIGWINCH
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, need to be in another file

Copy link
Copy Markdown
Contributor Author

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere merged commit 14097df into scaleway:v2 May 1, 2020
@remyleone remyleone linked an issue May 3, 2020 that may be closed by this pull request
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
* add schedule backup

* Disable update when IsBackupScheduleDisabled is false in create
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement scw server attach

3 participants