fix(core): disable check args exist valid for raw#788
Merged
loicbourgois merged 6 commits intov2from Mar 24, 2020
Merged
Conversation
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
loicbourgois
suggested changes
Mar 18, 2020
Contributor
loicbourgois
left a comment
loicbourgois
left a comment
There was a problem hiding this comment.
Can we add a test, so we're sure this bug doesn't come back ?
Co-Authored-By: Loïc Bourgois <loic@bourgois.pro>
loicbourgois
suggested changes
Mar 18, 2020
loicbourgois
suggested changes
Mar 18, 2020
internal/namespaces/autocomplete/testdata/test-autocomplete-bash-level1.stdout.golden
Outdated
Show resolved
Hide resolved
| })) | ||
| } | ||
|
|
||
| func Test_RawArgs(t *testing.T) { |
Contributor
There was a problem hiding this comment.
shoudn't we have a testcobraRun func that only test cobraRun ?
I find it strnage that we hav to test an entire command.
Shouldn't we only call cobraRun() in the test ?
Contributor
Author
There was a problem hiding this comment.
we could 😄 I'll fix that
Contributor
Author
There was a problem hiding this comment.
Though it may be more complicated 🤔
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #787
Signed-off-by: Patrik Cyvoct pcyvoct@scaleway.com