Skip to content

feat(baremetal): add create server with type#768

Merged
remyleone merged 67 commits intoscaleway:v2from
remyleone:create_server
Apr 9, 2020
Merged

feat(baremetal): add create server with type#768
remyleone merged 67 commits intoscaleway:v2from
remyleone:create_server

Conversation

@remyleone
Copy link
Copy Markdown
Member

No description provided.

Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
@remyleone remyleone self-assigned this Mar 13, 2020
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go Outdated
@remyleone remyleone force-pushed the create_server branch 2 times, most recently from 219b11b to 5fa5540 Compare March 19, 2020 15:31
@remyleone remyleone changed the title WIP: feat(baremetal): Add create server with type feat(baremetal): Add create server with type Mar 19, 2020
@loicbourgois loicbourgois changed the title feat(baremetal): Add create server with type feat(baremetal): add create server with type Mar 19, 2020
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread cmd/scw/testdata/test-all-usage-baremetal-server-create-usage.stderr.golden Outdated
Comment thread cmd/scw/testdata/test-all-usage-baremetal-server-create-usage.stderr.golden Outdated
Comment thread cmd/scw/testdata/test-all-usage-baremetal-server-create-usage.stderr.golden Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/helpers_test.go
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/helpers_test.go
Comment thread internal/namespaces/baremetal/v1alpha1/helpers_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go
Comment thread internal/namespaces/baremetal/v1alpha1/custom.go
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread cmd/scw/testdata/test-all-usage-baremetal-server-create-usage.stderr.golden Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_create_test.go Outdated
Comment thread internal/namespaces/baremetal/v1alpha1/custom_server_test.go
Comment thread internal/namespaces/baremetal/v1alpha1/helpers_test.go Outdated
Copy link
Copy Markdown
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread internal/namespaces/baremetal/v1alpha1/custom_server.go
Copy link
Copy Markdown
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 0c5827c into scaleway:v2 Apr 9, 2020
@remyleone remyleone added the elastic-metal Elastic-metal issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

elastic-metal Elastic-metal issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants