tests(instance): use sdk vcr (go-vcr.v4) for instance package#5089
Merged
remyleone merged 1 commit intoscaleway:masterfrom Oct 29, 2025
Merged
tests(instance): use sdk vcr (go-vcr.v4) for instance package#5089remyleone merged 1 commit intoscaleway:masterfrom
remyleone merged 1 commit intoscaleway:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5089 +/- ##
==========================================
+ Coverage 57.43% 57.47% +0.03%
==========================================
Files 308 308
Lines 67126 67151 +25
==========================================
+ Hits 38552 38593 +41
+ Misses 27140 27121 -19
- Partials 1434 1437 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
remyleone
approved these changes
Oct 29, 2025
This was referenced Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts the migration of tests cassettes from
go-vcr(v1.20) togo-vcr.v4with the instance package. This will be done by gradually making packages use the vcr client from the sdk-go.The biggest benefit of this change will be to be able to use the
SkipRequestLatencyoption on the recorder that was introduced in v3. This will allow us to replay cassettes a lot faster because interactions will not simulate the requests' duration anymore, therefore making the CI faster.