Skip to content

fix(rdb): add explicit backup deletion in test AfterFunc to prevent quota exhaustion #5047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 2 commits into from
Oct 10, 2025
Merged

fix(rdb): add explicit backup deletion in test AfterFunc to prevent quota exhaustion #5047

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9cb186
fix(rdb): add explicit backup deletion in test AfterFunc to prevent q…
jremy42 Oct 10, 2025
c4fbe17
Merge branch 'master' into fix/rdb-backup-cleanup
jremy42 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 35 additions & 6 deletions internal/namespaces/rdb/v1/custom_backup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,14 @@ func Test_CreateBackup(t *testing.T) {
},
),
),
Cmd: "scw rdb backup create name=foobar expires-at=2032-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
Check: core.TestCheckGolden(),
AfterFunc: deleteInstance(),
Cmd: "scw rdb backup create name=foobar expires-at=2032-01-02T15:04:05-07:00 instance-id={{ .Instance.ID }} database-name=rdb --wait",
Check: core.TestCheckGolden(),
AfterFunc: core.AfterFuncCombine(
core.AfterFuncWhenUpdatingCassette(
core.ExecAfterCmd("scw rdb backup delete {{ .CmdResult.ID }}"),
),
deleteInstance(),
),
DefaultRegion: scw.RegionNlAms,
}))
}
Expand Down Expand Up @@ -54,7 +59,12 @@ func Test_RestoreBackup(t *testing.T) {
core.TestCheckGolden(),
core.TestCheckExitCode(0),
),
AfterFunc: deleteInstance(),
AfterFunc: core.AfterFuncCombine(
core.AfterFuncWhenUpdatingCassette(
core.ExecAfterCmd("scw rdb backup delete {{ .Backup.ID }}"),
),
deleteInstance(),
),
}))
}

Expand All @@ -81,7 +91,12 @@ func Test_ExportBackup(t *testing.T) {
core.TestCheckGolden(),
core.TestCheckExitCode(0),
),
AfterFunc: deleteInstance(),
AfterFunc: core.AfterFuncCombine(
core.AfterFuncWhenUpdatingCassette(
core.ExecAfterCmd("scw rdb backup delete {{ .Backup.ID }}"),
),
deleteInstance(),
),
}))
}

Expand All @@ -105,6 +120,9 @@ func Test_DownloadBackup(t *testing.T) {
core.TestCheckExitCode(0),
),
AfterFunc: core.AfterFuncCombine(
core.AfterFuncWhenUpdatingCassette(
core.ExecAfterCmd("scw rdb backup delete {{ .Backup.ID }}"),
),
deleteInstance(),
func(_ *core.AfterFuncCtx) error {
err := os.Remove("simple_dump")
Expand All @@ -131,6 +149,9 @@ func Test_DownloadBackup(t *testing.T) {
core.TestCheckExitCode(0),
),
AfterFunc: core.AfterFuncCombine(
core.AfterFuncWhenUpdatingCassette(
core.ExecAfterCmd("scw rdb backup delete {{ .Backup.ID }}"),
),
deleteInstance(),
func(_ *core.AfterFuncCtx) error {
err := os.Remove("no_previous_export_dump")
Expand Down Expand Up @@ -169,6 +190,14 @@ func Test_ListBackup(t *testing.T) {
core.TestCheckGolden(),
core.TestCheckExitCode(0),
),
AfterFunc: deleteInstance(),
AfterFunc: core.AfterFuncCombine(
core.AfterFuncWhenUpdatingCassette(
core.AfterFuncCombine(
core.ExecAfterCmd("scw rdb backup delete {{ .BackupA.ID }}"),
core.ExecAfterCmd("scw rdb backup delete {{ .BackupB.ID }}"),
),
),
deleteInstance(),
),
}))
}
Loading