feat(instance): remove deprecated and duplicated IP fields#5037
Merged
remyleone merged 1 commit intoscaleway:masterfrom Oct 8, 2025
Merged
feat(instance): remove deprecated and duplicated IP fields#5037remyleone merged 1 commit intoscaleway:masterfrom
remyleone merged 1 commit intoscaleway:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #5037 +/- ##
===========================================
- Coverage 75.45% 56.26% -19.20%
===========================================
Files 202 308 +106
Lines 44323 78080 +33757
===========================================
+ Hits 33444 43930 +10486
- Misses 9653 32743 +23090
- Partials 1226 1407 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
remyleone
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of changes in the output of the
scw instance server getcommand:EnableIPv6field as it is deprecated and its value is always false, even if the server has IPv6.PublicIP.Xxxfields as they are duplicated in the 'Public IPs' section below.IPv6section as it is always empty, even if the server has IPv6, and that the actual IPv6 addresses can be found either in the 'Public IPs' or in the 'Private IPs' section.