Skip to content

chore(instance): add EndOfService warning on server get, create and update#4749

Merged
remyleone merged 3 commits intoscaleway:masterfrom
Mia-Cross:instance_warning_for_eos_server_types
May 23, 2025
Merged

chore(instance): add EndOfService warning on server get, create and update#4749
remyleone merged 3 commits intoscaleway:masterfrom
Mia-Cross:instance_warning_for_eos_server_types

Conversation

@Mia-Cross
Copy link
Contributor

Closes #4691

@Mia-Cross Mia-Cross self-assigned this May 21, 2025
@Mia-Cross Mia-Cross added enhancement instance Instance issues, bugs and feature requests priority:high New features labels May 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2025

Codecov Report

Attention: Patch coverage is 46.51163% with 46 lines in your changes missing coverage. Please review.

Project coverage is 55.18%. Comparing base (5bf53e0) to head (7485fde).
Report is 639 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/instance/v1/helpers_types.go 0.00% 35 Missing ⚠️
internal/namespaces/instance/v1/custom_server.go 75.75% 5 Missing and 3 partials ⚠️
...nal/namespaces/instance/v1/custom_server_create.go 83.33% 2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (7485fde). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (7485fde)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4749       +/-   ##
===========================================
- Coverage   75.45%   55.18%   -20.27%     
===========================================
  Files         202      312      +110     
  Lines       44323    80091    +35768     
===========================================
+ Hits        33444    44199    +10755     
- Misses       9653    34480    +24827     
- Partials     1226     1412      +186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross force-pushed the instance_warning_for_eos_server_types branch from 76a769c to 99b6de2 Compare May 22, 2025 15:09
@Mia-Cross Mia-Cross marked this pull request as ready for review May 23, 2025 14:37
@Mia-Cross Mia-Cross requested a review from a team as a code owner May 23, 2025 14:37
@remyleone remyleone added this pull request to the merge queue May 23, 2025
Merged via the queue into scaleway:master with commit 4e33c67 May 23, 2025
14 checks passed
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request May 26, 2025
@Mia-Cross Mia-Cross deleted the instance_warning_for_eos_server_types branch December 19, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement instance Instance issues, bugs and feature requests priority:high New features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a warning for deprecated instance types on create, get and update

3 participants