feat: add support for a powershell install script for a dev env#4317
Merged
remyleone merged 3 commits intoscaleway:masterfrom Dec 3, 2024
Merged
feat: add support for a powershell install script for a dev env#4317remyleone merged 3 commits intoscaleway:masterfrom
remyleone merged 3 commits intoscaleway:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4317 +/- ##
==========================================
- Coverage 75.45% 70.96% -4.50%
==========================================
Files 202 292 +90
Lines 44323 65261 +20938
==========================================
+ Hits 33444 46312 +12868
- Misses 9653 17326 +7673
- Partials 1226 1623 +397 ☔ View full report in Codecov by Sentry. |
karibou
reviewed
Dec 2, 2024
karibou
left a comment
karibou
left a comment
There was a problem hiding this comment.
Might be better to use some kind of placeholder rather than an actual real ssh-key
scripts/windows/install.ps1
Outdated
| } | ||
|
|
||
| # Replace this line with your own SSH key | ||
| echo "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIM6Lfs9IrfEUsw2oALOKucAqjeJo3vdADJAZS0BrJ4Vl rleone@scaleway.com" > "C:\ProgramData\ssh\administrators_authorized_keys" |
There was a problem hiding this comment.
Might be better to use some kind of placeholder rather than an actual real ssh-key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: