feat(instance): server create with custom iops volumes#4140
Merged
remyleone merged 4 commits intoscaleway:masterfrom Oct 1, 2024
Merged
feat(instance): server create with custom iops volumes#4140remyleone merged 4 commits intoscaleway:masterfrom
remyleone merged 4 commits intoscaleway:masterfrom
Conversation
Code was moved but not improved as the goal was not to break cassettes.
Codelax
force-pushed
the
refactor/instance-server-create-volumes
branch
from
12f5106 to
066d6ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4140 +/- ##
==========================================
- Coverage 75.45% 72.50% -2.96%
==========================================
Files 202 289 +87
Lines 44323 54228 +9905
==========================================
+ Hits 33444 39316 +5872
- Misses 9653 13298 +3645
- Partials 1226 1614 +388 ☔ View full report in Codecov by Sentry. |
Codelax
changed the title
remyleone
reviewed
Oct 1, 2024
remyleone
reviewed
Oct 1, 2024
| vb.VolumeType = instance.VolumeVolumeTypeLSSD | ||
| case "b", "block": | ||
| vb.VolumeType = instance.VolumeVolumeTypeBSSD | ||
| case "s", "scratch": |
Member
There was a problem hiding this comment.
scratch is missing from the examples
remyleone
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.