Skip to content

feat(registry): deprecate delete tag force field #3158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 1 commit into from
Jun 1, 2023
Merged

feat(registry): deprecate delete tag force field #3158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/scw/testdata/test-all-usage-registry-tag-delete-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ USAGE:

ARGS:
tag-id UUID of the tag
[force] If two tags share the same digest the deletion will fail unless this parameter is set to true
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

DEPRECATED ARGS:
[force] If two tags share the same digest the deletion will fail unless this parameter is set to true (deprecated)

FLAGS:
-h, --help help for delete

Expand Down
2 changes: 1 addition & 1 deletion docs/commands/registry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ scw registry tag delete <tag-id ...> [arg=value ...]
| Name | | Description |
|------|---|-------------|
| tag-id | Required | UUID of the tag |
| force | | If two tags share the same digest the deletion will fail unless this parameter is set to true |
| ~~force~~ | Deprecated | If two tags share the same digest the deletion will fail unless this parameter is set to true (deprecated) |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down
4 changes: 2 additions & 2 deletions internal/namespaces/registry/v1/registry_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,9 +638,9 @@ func registryTagDelete() *core.Command {
},
{
Name: "force",
Short: `If two tags share the same digest the deletion will fail unless this parameter is set to true`,
Short: `If two tags share the same digest the deletion will fail unless this parameter is set to true (deprecated)`,
Required: false,
Deprecated: false,
Deprecated: true,
Positional: false,
},
core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
Expand Down