feat: check for api key expiration date#3049
Merged
Codelax merged 4 commits intoscaleway:masterfrom Apr 21, 2023
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| delete(i.Request.Headers, "x-auth-token") | ||
| delete(i.Request.Headers, "X-Auth-Token") | ||
| i.Request.URL = regexp.MustCompile("organization_id=[0-9a-f-]{36}").ReplaceAllString(i.Request.URL, "organization_id=11111111-1111-1111-1111-111111111111") | ||
| i.Request.URL = regexp.MustCompile(`api\.scaleway\.com/account/v1/tokens/[0-9a-f-]{36}`).ReplaceAllString(i.Request.URL, "api.scaleway.com/account/v1/tokens/11111111-1111-1111-1111-111111111111") |
Check failure
Code scanning / CodeQL
Missing regular expression anchor
| delete(i.Request.Headers, "X-Auth-Token") | ||
| i.Request.URL = regexp.MustCompile("organization_id=[0-9a-f-]{36}").ReplaceAllString(i.Request.URL, "organization_id=11111111-1111-1111-1111-111111111111") | ||
| i.Request.URL = regexp.MustCompile(`api\.scaleway\.com/account/v1/tokens/[0-9a-f-]{36}`).ReplaceAllString(i.Request.URL, "api.scaleway.com/account/v1/tokens/11111111-1111-1111-1111-111111111111") | ||
| i.Request.URL = regexp.MustCompile(`api\.scaleway\.com/iam/v1alpha1/api-keys/SCW[0-9A-Z]{17}`).ReplaceAllString(i.Request.URL, "api.scaleway.com/iam/v1alpha1/api-keys/SCWXXXXXXXXXXXXXXXXX") |
Check failure
Code scanning / CodeQL
Missing regular expression anchor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3049 +/- ##
==========================================
+ Coverage 75.56% 75.75% +0.19%
==========================================
Files 166 168 +2
Lines 36476 36513 +37
==========================================
+ Hits 27563 27662 +99
+ Misses 7962 7891 -71
- Partials 951 960 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return err | ||
| } | ||
| if !*UpdateCassettes { | ||
| apiKey.AccessKey = "SCWXXXXXXXXXXXXXXXXX" |
Member
There was a problem hiding this comment.
I know this is not the scope of this PR but just to add a note, this should be a constant as it's used a lot in the codebase. Same for 11111111-1111-1111-1111-111111111111 in place of project/organization id.
quantumsheep
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2648
Checks example: