Skip to content

fix(instance): fix documentation on server update#1527

Merged
remyleone merged 1 commit intoscaleway:masterfrom
jtherin:fixinstanceupdatedoc
Nov 13, 2020
Merged

fix(instance): fix documentation on server update#1527
remyleone merged 1 commit intoscaleway:masterfrom
jtherin:fixinstanceupdatedoc

Conversation

@jtherin
Copy link
Copy Markdown
Member

@jtherin jtherin commented Nov 13, 2020

before:

  Apply the given security group to a given server
    scw instance server update
  Put a given server in the given placement group. Server must be off
    scw instance server update

after:

  Apply the given security group to a given server
    scw instance server update 11111111-1111-1111-1111-111111111111 security-group-id=11111111-1111-1111-1111-111111111111

  Put a given server in the given placement group. Server must be off
    scw instance server update 11111111-1111-1111-1111-111111111111 placement-group=11111111-1111-1111-1111-111111111111

@jtherin jtherin force-pushed the fixinstanceupdatedoc branch from 76ff21a to 2b7cb4f Compare November 13, 2020 12:04
Sh4d1
Sh4d1 approved these changes Nov 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 454fcaa into scaleway:master Nov 13, 2020
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Sh4d1 Sh4d1 Sh4d1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtherin @Sh4d1 @remyleone