Skip to content

improvement: Auto detect build target in attach if not specified#7277

Merged
tgodzik merged 2 commits intoscalameta:mainfrom
tgodzik:auto-detect-buildtarget
Jun 17, 2025
Merged

improvement: Auto detect build target in attach if not specified#7277
tgodzik merged 2 commits intoscalameta:mainfrom
tgodzik:auto-detect-buildtarget

Conversation

@tgodzik
Copy link
Copy Markdown
Contributor

@tgodzik tgodzik commented Mar 6, 2025

No description provided.

@masonedmison
Copy link
Copy Markdown
Contributor

masonedmison commented May 30, 2025

@tgodzik This seems pretty useful. Anything I can do to help get this merged in?

@tgodzik
Copy link
Copy Markdown
Contributor Author

tgodzik commented Jun 6, 2025

@tgodzik This seems pretty useful. Anything I can do to help get this merged in?

I had some issues writing a test for this and got stuck. I will try and look again into this

@tgodzik tgodzik force-pushed the auto-detect-buildtarget branch 2 times, most recently from 7d440d6 to 7b9d56a Compare June 6, 2025 17:36
@tgodzik tgodzik marked this pull request as ready for review June 6, 2025 17:36
@tgodzik
Copy link
Copy Markdown
Contributor Author

tgodzik commented Jun 6, 2025

Ok, I think it's good now. I added an attach test, which was not present before.

@tgodzik tgodzik requested a review from kasiaMarek June 6, 2025 17:37
@tgodzik tgodzik force-pushed the auto-detect-buildtarget branch from 7b9d56a to 477ffdb Compare June 6, 2025 17:38
@tgodzik tgodzik merged commit 140af47 into scalameta:main Jun 17, 2025
23 of 25 checks passed
@tgodzik tgodzik deleted the auto-detect-buildtarget branch June 17, 2025 17:26
tgodzik added a commit that referenced this pull request Apr 28, 2026
* improvement: Auto detect build target in attach if not specified

* improvement: Add attach test

(cherry picked from commit 140af47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants