Add Filesystem API to jars#963
Open
Arthurm1 wants to merge 1 commit into
Open
Conversation
This was referenced Apr 27, 2022
b01aa0f to
cdbb008
Compare
8b47199 to
a3196d5
Compare
Contributor
Author
|
@kpodsiad Do you know how do fix the ESLint errors here? I'm trying to implement an interface method but I don't need the parameters - hence they're unused. I thought prefixing with I've copied Microsoft's example method from here |
Member
|
@Arthurm1 you try different options that disable ESLint errors for unused params - https://eslint.org/docs/rules/no-unused-vars#varsignorepattern. |
a3196d5 to
eb2c7e5
Compare
Contributor
Author
|
@kpodsiad That works thanks! |
eb2c7e5 to
6205908
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to scalameta/metals#3750
and scalameta/metals-languageclient#461