Skip to content

Add Filesystem API to jars#963

Open
Arthurm1 wants to merge 1 commit into
scalameta:mainfrom
Arthurm1:jar_file_system
Open

Add Filesystem API to jars#963
Arthurm1 wants to merge 1 commit into
scalameta:mainfrom
Arthurm1:jar_file_system

Conversation

@Arthurm1
Copy link
Copy Markdown
Contributor

@Arthurm1 Arthurm1 commented Apr 27, 2022

@Arthurm1
Copy link
Copy Markdown
Contributor Author

@kpodsiad Do you know how do fix the ESLint errors here? I'm trying to implement an interface method but I don't need the parameters - hence they're unused. I thought prefixing with _ caused the errors to be ignored but that only works with local compilation, not the github actions ESLint stage.

I've copied Microsoft's example method from here

@kpodsiad
Copy link
Copy Markdown
Member

kpodsiad commented Jun 11, 2022

@Arthurm1 you try different options that disable ESLint errors for unused params - https://eslint.org/docs/rules/no-unused-vars#varsignorepattern. varsIgnorePattern might be a could candidate - I used this to suppress errors for _ here

@Arthurm1
Copy link
Copy Markdown
Contributor Author

@kpodsiad That works thanks!

@Arthurm1 Arthurm1 marked this pull request as ready for review July 7, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants