This repository was archived by the owner on Dec 22, 2021. It is now read-only.
A port of mutable.Queue from the old collections #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes mutable.LinkedList and mutable.MutableList. They were already deprecated in 2.12 and are now package-private. We should consider simplifying the implementation of Queue so that they can be removed entirely in the future.
Contributor
|
I’m not sure it’s worth adding a package private collection and remove it soon. I would rather get |
Contributor
Author
|
Switching to ArrayDeque is probably a good idea for a Queue replacement. I made the helper classes package-private so we could easily remove them when changing the implementation without concern for compatibility. |
Contributor
Author
|
I'm merging this because I have further dependencies on mutable.Queue in my integration branch. We should still replace it with #49 before 2.13.0-M4. |
szeiger
added a commit
that referenced
this pull request
Feb 6, 2018
The branch was outdated without causing proper merge conflicts.
szeiger
added a commit
that referenced
this pull request
Feb 6, 2018
Fix problems caused by merging #336
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes mutable.LinkedList and mutable.MutableList. They were
already deprecated in 2.12 and are now package-private. We should
consider simplifying the implementation of Queue so that they can be
removed entirely in the future.