Update refactored sample code for 依存性の注入によるリファクタリング#1475
Open
kazuf3 wants to merge 4 commits intoscala-text:masterfrom
Open
Update refactored sample code for 依存性の注入によるリファクタリング#1475kazuf3 wants to merge 4 commits intoscala-text:masterfrom
kazuf3 wants to merge 4 commits intoscala-text:masterfrom
Conversation
説明では DI の実行後, UserServiceImpl から UserRepositoryImpl への依存性がなくなっ ているとのことであったが， サンプルでは, - UserServiceImpl の実装を UserService に移植し, - UserService に UserRepository への依存性を注入し, - UserServiceImpl はなおも UserRepositoryImpl に依存する となっていた. これに対し,説明に合わせるための修正を実施した.
kmizu
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
説明では DI の実行後, UserServiceImpl から UserRepositoryImpl への依存性がなくなっ ているとのことであったが， サンプルでは,
これに対し,説明に合わせるための修正を実施した.