Skip to content

Conversation

@cgewecke
Copy link
Member

@cgewecke cgewecke commented Feb 28, 2024

See #870 - it looked like instrumentation was getting stripped out by viaIR, but actually some hashes are being displaced onto higher PUSHn opcodes that the collector isn't tracking.

(There's still an unhit line in #870 however ... waiting on answer to this #870 (comment))

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (32029b4) to head (b2e9859).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
+ Coverage   96.47%   96.50%   +0.02%     
==========================================
  Files          19       19              
  Lines        1021     1029       +8     
==========================================
+ Hits          985      993       +8     
  Misses         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgewecke cgewecke merged commit 943a6fe into master Feb 29, 2024
@cgewecke cgewecke deleted the viaIR-opcodes-fix branch February 29, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants