Skip to content

fix compile error with JDK 23#530

Merged
eed3si9n merged 1 commit intosbt:developfrom
xuwei-k:import-java-io-IO
Sep 7, 2024
Merged

fix compile error with JDK 23#530
eed3si9n merged 1 commit intosbt:developfrom
xuwei-k:import-java-io-IO

Conversation

@xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Sep 7, 2024

https://bugs.openjdk.org/browse/JDK-8305457

[error] sbt-assempby-project-dir/src/main/scala/sbtassembly/Assembly.scala:355:13: reference to IO is ambiguous;
[error] it is imported twice in the same scope by
[error] import java.io._
[error] and import sbt.{File, Logger, _}
[error]             IO.delete(output)
[error]             ^
[error] sbt-assempby-project-dir/src/main/scala/sbtassembly/Assembly.scala:371:13: reference to IO is ambiguous;
[error] it is imported twice in the same scope by
[error] import java.io._
[error] and import sbt.{File, Logger, _}
[error]             IO.delete(outputWithHash)
[error]             ^
[error] sbt-assempby-project-dir/src/main/scala/sbtassembly/Assembly.scala:379:31: reference to IO is ambiguous;
[error] it is imported twice in the same scope by
[error] import java.io._
[error] and import sbt.{File, Logger, _}
[error]               if (tmp.exists) IO.delete(tmp)
[error]                               ^
[error] sbt-assempby-project-dir/src/main/scala/sbtassembly/Assembly.scala:381:15: reference to IO is ambiguous;
[error] it is imported twice in the same scope by
[error] import java.io._
[error] and import sbt.{File, Logger, _}
[error]               IO.write(builtAssemblyJar, shellScript.map(_ + "\n").mkString, append = false)
[error]               ^
[error] sbt-assempby-project-dir/src/main/scala/sbtassembly/Assembly.scala:381:78: not found: value append
[error]               IO.write(builtAssemblyJar, shellScript.map(_ + "\n").mkString, append = false)
[error]                                                                              ^
[error] sbt-assempby-project-dir/src/main/scala/sbtassembly/Assembly.scala:382:69: reference to IO is ambiguous;
[error] it is imported twice in the same scope by
[error] import java.io._
[error] and import sbt.{File, Logger, _}
[error]               Using.fileOutputStream(true)(builtAssemblyJar)(out => IO.transfer(tmp, out))
[error]                                                                     ^
[error] sbt-assempby-project-dir/src/main/scala/sbtassembly/Assembly.scala:383:15: reference to IO is ambiguous;
[error] it is imported twice in the same scope by
[error] import java.io._
[error] and import sbt.{File, Logger, _}
[error]               IO.delete(tmp)
[error]               ^
[error] sbt-assempby-project-dir/src/main/scala/sbtassembly/Assembly.scala:533:13: reference to IO is ambiguous;
[error] it is imported twice in the same scope by
[error] import java.io._
[error] and import sbt.{File, Logger, _}
[error]             IO.delete(previousOutput.get)
[error]             ^
[error] sbt-assempby-project-dir/src/main/scala/sbtassembly/Assembly.scala:566:15: reference to IO is ambiguous;
[error] it is imported twice in the same scope by
[error] import java.io._
[error] and import sbt.{File, Logger, _}
[error]               IO.transfer(inputStream, outputStream)
[error]               ^

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 124a3b4 into sbt:develop Sep 7, 2024
@xuwei-k xuwei-k deleted the import-java-io-IO branch September 7, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants