Merged
Conversation
Author
|
@eed3si9n this PR would be ready to squash-merge from my side. It exposes the Windows bug in #472 |
Member
I just created a branch called 1.x out of 1.2.0 - https://github.com/sbt/sbt-assembly/tree/1.x |
Author
|
Done in #473 |
This was referenced Oct 4, 2022
|
Hey man,
I just wanna kindly follow up on a new release for sbt-assembly. Thanks in
advance
…On Wed, Oct 5, 2022 at 7:28 PM eugene yokota ***@***.***> wrote:
Merged #471 <#471> into develop.
—
Reply to this email directly, view it on GitHub
<#471 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRY7Q3GTRJM5F2YZAOSC3DWBW3DTANCNFSM5ZUPXL6Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm noticing an error on Windows for
2.0.0-RC1which was not there under1.2.0(will create a ticket for that).As a first step for fixing this it would be good if the CI discovered and exposed the error.
I'm hoping that adding Windows to the build matrix already does so.