Skip to content

fix: TrimEditor error: 'bytes != null': is not true #95 #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
domliang wants to merge 5 commits into from
Closed

fix: TrimEditor error: 'bytes != null': is not true #95 #99

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a710ea1
fix:#95 fix the error TrimEditor error: 'bytes != null': is not true …
domliang Apr 1, 2021
6649dda
Revert "fix:#95 fix the error TrimEditor error: 'bytes != null': is n…
domliang Apr 1, 2021
246f4ce
fix:TrimEditor error: 'bytes != null': is not true #95
domliang Apr 1, 2021
c8045d1
Merge branch 'master' of github.com:sbis04/video_trimmer
domliang Jul 1, 2021
40ed272
Merge branch 'sbis04:master' into master
domliang Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/src/thumbnail_viewer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ class ThumbnailViewer extends StatelessWidget {
double _eachPart = videoDuration / numberOfThumbnails;

List<Uint8List> _byteList = [];

// the cache of last thumbnail
Uint8List _lastBytes;
Copy link
Contributor

@jonasN5 jonasN5 May 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Uint8List? _lastBytes;; note the ?. Generates an error in null safety otherwise since not declared.

Copy link
Contributor Author

@domliang domliang Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it

Copy link
Contributor Author

@domliang domliang Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its update in this pr #115

for (int i = 1; i <= numberOfThumbnails; i++) {
Uint8List _bytes;
_bytes = await VideoThumbnail.thumbnailData(
Expand All @@ -42,6 +43,13 @@ class ThumbnailViewer extends StatelessWidget {
quality: quality,
);

// if current thumbnail is null use the last thumbnail
if (_bytes != null) {
_lastBytes = _bytes;
} else {
_bytes = _lastBytes;
}

_byteList.add(_bytes);

yield _byteList;
Expand Down