Skip to content

Conversation

@sceiler
Copy link
Contributor

@sceiler sceiler commented Aug 19, 2021

Description

This resolves #172. The change will better prevent typos because it forces the use of an enum when using HTTP methods.

Motivation and Context

#172

How Has This Been Tested?

Ran unit tests.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (change which improves current code base; please describe the change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Screenshots (if appropriate):

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed locally
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #175 (7d5a270) into 1.1.0_dev (b4c8390) will increase coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##             1.1.0_dev     #175      +/-   ##
===============================================
+ Coverage        58.89%   59.59%   +0.69%     
- Complexity         132      134       +2     
===============================================
  Files                8        9       +1     
  Lines              635      646      +11     
  Branches            44       44              
===============================================
+ Hits               374      385      +11     
  Misses             232      232              
  Partials            29       29              
Flag Coverage Δ
unittests 59.59% <100.00%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../main/java/com/saucelabs/saucerest/HttpMethod.java 100.00% <100.00%> (ø)
...c/main/java/com/saucelabs/saucerest/SauceREST.java 66.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c8390...7d5a270. Read the comment docs.

@sceiler sceiler requested a review from diemol August 19, 2021 10:36
@sceiler sceiler linked an issue Aug 19, 2021 that may be closed by this pull request
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sceiler!

@sceiler sceiler merged commit 8165c4c into 1.1.0_dev Aug 19, 2021
@sceiler sceiler deleted the refactor-use_HttpMethod_Enum branch August 19, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace hardcoded HTTP method string to use pre-defined ENUM

4 participants