Skip to content

Conversation

@sceiler
Copy link
Contributor

@sceiler sceiler commented Jul 17, 2021

Description

This resolves #161.

Motivation and Context

This resolves #161.

How Has This Been Tested?

Unit tests and E2E test.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (change which improves current code base; please describe the change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Screenshots (if appropriate):

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed locally
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

sceiler and others added 13 commits July 16, 2021 22:14
#153)

* Replace travis-ci config with GitHub action to create a CI build including codecov report and upload.

* Replace Travis-CI badge with GitHub action badge

* Fix GitHub action badge

* Replace equal sign paragraph in readme with something more dynamic.
Bumps commons-io from 2.10.0 to 2.11.0.

---
updated-dependencies:
- dependency-name: commons-io:commons-io
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
- added unit tests for all scenarios
- made function return response from server
- added error explanation
- added additional sauce exception for not found
Bumps [failsafe](https://github.com/jhalterman/failsafe) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/jhalterman/failsafe/releases)
- [Changelog](https://github.com/jhalterman/failsafe/blob/master/CHANGES.md)
- [Commits](failsafe-lib/failsafe@failsafe-2.4.0...failsafe-2.4.1)

---
updated-dependencies:
- dependency-name: net.jodah:failsafe
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…lsafe-2.4.1

Bump failsafe from 2.4.0 to 2.4.1
Bumps [failsafe](https://github.com/failsafe-lib/failsafe) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/failsafe-lib/failsafe/releases)
- [Changelog](https://github.com/failsafe-lib/failsafe/blob/master/CHANGELOG.md)
- [Commits](failsafe-lib/failsafe@failsafe-2.4.1...failsafe-2.4.2)

---
updated-dependencies:
- dependency-name: net.jodah:failsafe
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…lsafe-2.4.2

Bump failsafe from 2.4.1 to 2.4.2
Bumps [maven-scm-plugin](https://github.com/apache/maven-scm) from 1.11.2 to 1.11.3.
- [Release notes](https://github.com/apache/maven-scm/releases)
- [Commits](apache/maven-scm@maven-scm-1.11.2...maven-scm-1.11.3)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-scm-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps maven-scm-provider-gitexe from 1.11.2 to 1.11.3.

---
updated-dependencies:
- dependency-name: org.apache.maven.scm:maven-scm-provider-gitexe
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…ven.plugins-maven-scm-plugin-1.11.3

Bump maven-scm-plugin from 1.11.2 to 1.11.3
…ven.scm-maven-scm-provider-gitexe-1.11.3

Bump maven-scm-provider-gitexe from 1.11.2 to 1.11.3
Currently CodeQL runs for every PR which causes issues because CodeQL works by comparing to prior runs which there are no if it is a brand-new branch,
@codecov-commenter
Copy link

Codecov Report

Merging #162 (0d4b178) into 1.1.0_dev (de94e88) will not change coverage.
The diff coverage is n/a.

❗ Current head 0d4b178 differs from pull request most recent head 05bb0f8. Consider uploading reports for the commit 05bb0f8 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             1.1.0_dev     #162   +/-   ##
============================================
  Coverage        57.97%   57.97%           
  Complexity         127      127           
============================================
  Files                8        8           
  Lines              621      621           
  Branches            41       41           
============================================
  Hits               360      360           
  Misses             232      232           
  Partials            29       29           
Flag Coverage Δ
unittests 57.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de94e88...05bb0f8. Read the comment docs.

Fix syntax error
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sceiler!

Update codeql-analysis.yml
@sceiler sceiler merged commit b4c8390 into 1.1.0_dev Aug 19, 2021
@sceiler sceiler deleted the refactor-deleteTunnel branch August 19, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor deleteTunnel() to return the actual response and add unit tests

4 participants