Skip to content

Conversation

@sceiler
Copy link
Contributor

@sceiler sceiler commented Jul 16, 2021

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (change which improves current code base; please describe the change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Screenshots (if appropriate):

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed locally
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

sceiler added 2 commits July 16, 2021 20:25
Update workflow to work on all pushes, PRs and also to run regularly. Workflow is also more descriptive. This is from CodeQLs repo.
Update codeql-analysis.yml
@codecov-commenter
Copy link

Codecov Report

Merging #159 (5f891e3) into 1.1.0_dev (bb1334f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             1.1.0_dev     #159   +/-   ##
============================================
  Coverage        57.97%   57.97%           
  Complexity         127      127           
============================================
  Files                8        8           
  Lines              621      621           
  Branches            41       41           
============================================
  Hits               360      360           
  Misses             232      232           
  Partials            29       29           
Flag Coverage Δ
unittests 57.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb1334f...5f891e3. Read the comment docs.

@sceiler sceiler merged commit de94e88 into 1.1.0_dev Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants