Implement sass --embedded in pure JS mode#2413
Draft
Conversation
ntkme
force-pushed
the
embedded-compiler
branch
from
8d7d4de to
7084da7
Compare
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
e66df5b to
d53fcc5
Compare
4 tasks
ntkme
force-pushed
the
embedded-compiler
branch
9 times, most recently
from
d7e6206 to
b3794eb
Compare
ntkme
force-pushed
the
embedded-compiler
branch
3 times, most recently
from
9112b44 to
54fabf3
Compare
ntkme
force-pushed
the
embedded-compiler
branch
8 times, most recently
from
257b4fd to
ac718ee
Compare
|
Would just like to add on top of using this to get Discourse on FreeBSD I just got Vikunja working. Both work flawlessly thank you for this change it's been a huge help. |
Contributor
Author
|
@nex3 Any updates on the |
Contributor
|
The only real blocker is merging a bunch of my JS type definitions which are currently living in a private package into Dart team owned sources. I'm in discussion with @srujzs about the best way to do that, and I may pitch in to help land it. If you'd like to help as well, we could probably loop you in. |
|
Hi @nex. Do you have an ETA for this PR? |
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2325.
Implementation
The actual isolate dispatcher and compilation dispatcher are nearly unchanged. However, I had to replace isolate with worker communication, and mock tons of small things that do not work on node.
Testing
Current Status
Functionally it's ready to merge. Cosmetically it's waiting on dart-sass (depends on node_interop) to migrate off the legacy js interop to avoid the confusion of mixing legacy and new js interop.
Because FreeBSD support has been requested a lot for ruby's sass-embedded gem, this patch has been bundled within sass-embedded gem.