Skip to content

[tekton-apps] - define pvc size 0.2.2#60

Merged
dmitry-mightydevops merged 19 commits intomainfrom
feature/tekton-apps-define-pvc-size-0.2.2
Feb 21, 2023
Merged

[tekton-apps] - define pvc size 0.2.2#60
dmitry-mightydevops merged 19 commits intomainfrom
feature/tekton-apps-define-pvc-size-0.2.2

Conversation

@dmitry-mightydevops
Copy link
Contributor

@dmitry-mightydevops dmitry-mightydevops commented Feb 20, 2023

Summary

  • add ability to define the PVC for tekton's buildpack and workspace PVCs to clean up the following alarms
    image

you define it this way at the component level. If they're not defined - then default values (10/5 will be used):

apps:
  - project: nmbl
    enabled: true
    ...

    components:
      - name: frontend
        repository: nmbl-frontend
        pipeline: buildpack-frontend-build-pipeline
        applicationURL: https://proxylegalstaging.com
        argocd:
          syncWave: 220
        tekton:
          workspacePVC: 15Gi         ------------ THIS
          buildpacksPVC: 25Gi        ------------ THIS
        eventlistener:
          template: buildpack-frontend-build-pipeline-trigger-template
          # TODO: Ksusha - pls fix once you finalize the PR
          # https://github.com/saritasa-nest/nmbl-frontend/pull/1#pullrequestreview-962791245
          gitWebhookBranches:
            - feature/add-ci-cd
        triggerBinding:
          - name: docker_registry_repository
            value: 833737135757.dkr.ecr.us-east-2.amazonaws.com/nmbl/staging/frontend
          - name: buildpack_builder_image
            value: 833737135757.dkr.ecr.us-east-2.amazonaws.com/nmbl/staging/buildpacks/paketo/builder:latest
          - name: buildpack_runner_image
            value: 833737135757.dkr.ecr.us-east-2.amazonaws.com/nmbl/staging/buildpacks/paketo/runner:latest
          - name: source_subpath
            value: dist
          - name: kubernetes_branch
            value: feature/add-staging

Linter

  • added the linter to the helm charts

If your configuration failed, you will not be able to merge the PR (see check below) and you can see the error in the actions/Lint & Test Charts job as shown below
image

image

by default ct scans only the changed charts

docs:

Cool future feature

Once the following PR is approved and released we can use skip_existing: true to avoid having the following errors
helm/chart-releaser-action#134

Error: error creating GitHub release saritasa-tekton-apps-0.2.2-alpha.2: POST https://api.github.com/repos/saritasa-nest/saritasa-devops-helm-charts/releases: 422 Validation Failed [{Resource:Release Field:tag_name Code:already_exists Message:}]

- name: Run chart-releaser
  uses: helm/[email protected]
  with:
     config: cr.yaml
     charts_dir: charts     
     skip_existing: true

@dmitry-mightydevops dmitry-mightydevops changed the title feature/tekton apps define pvc size 0.2.2 [tekton-apps]: define pvc size 0.2.2 Feb 20, 2023
@dmitry-mightydevops dmitry-mightydevops changed the title [tekton-apps]: define pvc size 0.2.2 [tekton-apps] - define pvc size 0.2.2 Feb 20, 2023
udaltsovra
udaltsovra previously approved these changes Feb 20, 2023
owlfog
owlfog previously approved these changes Feb 20, 2023
rustofaer
rustofaer previously approved these changes Feb 20, 2023
populov
populov previously approved these changes Feb 20, 2023
@MikhailKorol-saritasa MikhailKorol-saritasa dismissed stale reviews from DanilaKazakevich, populov, and themself via 65b14fa February 21, 2023 05:26
@dmitry-mightydevops dmitry-mightydevops merged commit 945397e into main Feb 21, 2023
@dmitry-mightydevops dmitry-mightydevops deleted the feature/tekton-apps-define-pvc-size-0.2.2 branch February 21, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Needs Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants