crowbar: Remove forgotten nodes from proposals #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 2, 2017
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
/tmp/d20170602-7645-1se92bd/.rubocop.yml: Style/AlignHash has the wrong names...
/tmp/d20170602-7645-1se92bd/.rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout
/tmp/d20170602-7645-1se92bd/.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
/tmp/d20170602-7645-1se92bd/.rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout
/tmp/d20170602-7645-1se92bd/.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: obsolete parameter AlignWith (for Lint/EndAlignment) found in /tmp/d20170602-7645-1se92bd/.rubocop.ymlAlignWithhas been renamed toEnforcedStyleAlignWith
3 tasks
vuntz
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgotten nodes are not removed from existing proposals (applied and
non-applied). While the webui removes non-existing nodes when displaying
a proposal, if only the API is used, applying a proposal with such
non-existing nodes may result in failures.
Closes #8
(cherry picked from commit a31a710)