collection and sap_hostagent: ansible-lint fixes#973
Merged
Conversation
- added .ansible/ to excludes, this is auto-created by pre-commit and contains the collection, on which the role excludes do not work - sap_hostagent: removed `ansible_become` from defaults, it does not belong in the role but in the playbook, and it triggers the no-role-prefix rule - sap_hostagent: changed some truthy values for consistency - sap_hostagent linting is fine now, it is commented out in the exclude list
ja9fuchs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collection: added
.ansible/to excludes, this is auto-created by pre-commit and contains the collection, on which the role excludes do not worksap_hostagent: removed
ansible_becomefrom defaults, it does not belong in the role but in the playbook, and it triggers the no-role-prefix rulesap_hostagent: changed some truthy values for consistency
sap_hostagent is now free of linter errors and included in checks