Skip to content

fixed link to sap_netweaver_preconfigure in section recommended#968

Closed
SunnyCrockett wants to merge 3 commits into
sap-linuxlab:devfrom
SunnyCrockett:main
Closed

fixed link to sap_netweaver_preconfigure in section recommended#968
SunnyCrockett wants to merge 3 commits into
sap-linuxlab:devfrom
SunnyCrockett:main

Conversation

@SunnyCrockett

Copy link
Copy Markdown
Contributor

No description provided.

@berndfinger berndfinger self-requested a review February 14, 2025 08:29
@marcelmamula

Copy link
Copy Markdown
Contributor

@SunnyCrockett When you do changes to dev branch, it is always required to source it from your forked dev branch.

Merging fork:main to upstream:dev is very bad idea.
sap-linuxlab:dev from SunnyCrockett:main

@berndfinger berndfinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berndfinger

Copy link
Copy Markdown
Member

@SunnyCrockett Thanks for reporting this.

Your PR contains commits which have already been merged to dev. So I created a new PR #970 , containing only the changed file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants