Skip to content

sap_ha_pacemaker_cluster: fix internal-error#966

Merged
ja9fuchs merged 1 commit into
sap-linuxlab:devfrom
ja9fuchs:fix-linting
Feb 14, 2025
Merged

sap_ha_pacemaker_cluster: fix internal-error#966
ja9fuchs merged 1 commit into
sap-linuxlab:devfrom
ja9fuchs:fix-linting

Conversation

@ja9fuchs
Copy link
Copy Markdown
Contributor

For some reason the LSR collection variable is in the way of the ansible syntax-check of some tools, when the task that calls the ha_cluster LSR uses import_role.
The same syntax works without errors when the task uses include_role instead.

Fixes galaxy-importer error "internal-error: Unexpected error code 1".

For some reason the LSR collection variable is in the way of the ansible
syntax-check of some tools, when the task that calls the ha_cluster LSR
uses `import_role`.
The same syntax works without errors when the task uses `include_role`
instead.

Fixes galaxy-importer error "internal-error: Unexpected error code 1".
Copy link
Copy Markdown
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Very refreshing to see all green checks

@ja9fuchs ja9fuchs merged commit b3f5a45 into sap-linuxlab:dev Feb 14, 2025
@sean-freeman
Copy link
Copy Markdown
Member

sean-freeman commented Feb 14, 2025

@ja9fuchs I'm 99.9999% sure you verified the difference in the logic between these two built-in modules, but for sanity purposes please find my own notes about the difference at the Playbook level.....

# Use include_role / include_tasks inside Ansible Task block, instead of import_roles.
# This ensures Ansible Roles, and the tasks within, will be parsed in sequence instead
# of parsing at Playbook initialisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants