sap_ha_pacemaker_cluster: fix internal-error#966
Merged
Conversation
For some reason the LSR collection variable is in the way of the ansible syntax-check of some tools, when the task that calls the ha_cluster LSR uses `import_role`. The same syntax works without errors when the task uses `include_role` instead. Fixes galaxy-importer error "internal-error: Unexpected error code 1".
marcelmamula
approved these changes
Feb 14, 2025
Contributor
marcelmamula
left a comment
There was a problem hiding this comment.
LGTM, Very refreshing to see all green checks
Member
|
@ja9fuchs I'm 99.9999% sure you verified the difference in the logic between these two built-in modules, but for sanity purposes please find my own notes about the difference at the Playbook level..... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason the LSR collection variable is in the way of the ansible syntax-check of some tools, when the task that calls the ha_cluster LSR uses
import_role.The same syntax works without errors when the task uses
include_roleinstead.Fixes galaxy-importer error "internal-error: Unexpected error code 1".