sap_ha_pacemaker_cluster: fix ASCS/ERS systemd#963
Merged
Conversation
1. When using the systemd start framework for SAP instances, the instance services must be registered on all nodes they are going to run on. This creates the systemd units consistently. 2. When using the SAPStartSrv resource, the related systemd units 'sapping' and 'sappong' must be enabled. + For convenience: tags added to enable role execution just for the NWAS post-installation tasks.
- Applies the same changes as for ASCS/ERS. - Moved task for sapservices file comments to after systemd unit registration to catch new entries too.
ja9fuchs
force-pushed
the
fix-nw-systemd
branch
from
b56c7df to
04d7c2b
Compare
marcelmamula
approved these changes
Feb 11, 2025
Contributor
marcelmamula
left a comment
marcelmamula
left a comment
There was a problem hiding this comment.
LGTM. Thank you for this nice improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues #961 and #962.
When using the systemd start framework for SAP instances, the instance services must be registered on all nodes they are going to run on. This creates the systemd units consistently.
When using the SAPStartSrv resource, the related systemd units 'sapping' and 'sappong' must be enabled.
Tested on RHEL