sap_ha_pacemaker_cluster: stonith location constraints#954
Merged
Conversation
- Moved default stonith setup into block to share conditionals. - New: Default location constraints when fence resources are defined per host - prevent per-host-fence resources from running on the targeted node.
marcelmamula
approved these changes
Feb 11, 2025
Contributor
marcelmamula
left a comment
There was a problem hiding this comment.
LGTM. Naming could be improved, but it works.
Tested on SLES4SAP 15 SP6 on GCP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New task
Adding default location constraints when fence resources are defined per host.
This prevents per-host fence resources from running on the same, targeted node.
Currently GCP has a default stonith definition that works this way.
Result on GCP:
Tested (on RHEL)
GCP: correct default resource and constraints configuration
AWS: runs the default fence resource task, then skips the constraints task as expected
Reference
https://cloud.google.com/solutions/sap/docs/sap-hana-ha-config-rhel#create_the_fencing_device_resources