Skip to content

sap_hana_preconfigure: fix check mode in two tasks #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berndfinger merged 1 commit into from
Feb 4, 2025
Merged

sap_hana_preconfigure: fix check mode in two tasks #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion roles/sap_hana_preconfigure/tasks/RedHat/generic/configure-thp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@
- name: Set THP to '{{ __sap_hana_preconfigure_fact_thp }}' on the running system
ansible.builtin.shell: echo '{{ __sap_hana_preconfigure_fact_thp }}' > /sys/kernel/mm/transparent_hugepage/enabled
changed_when: true
when: __sap_hana_preconfigure_register_thp_status_before.stdout.split('[')[1].split(']')[0] != __sap_hana_preconfigure_fact_thp
when:
- not ansible_check_mode
- __sap_hana_preconfigure_register_thp_status_before.stdout.split('[')[1].split(']')[0] != __sap_hana_preconfigure_fact_thp

- name: Configure - Get the status of THP
ansible.builtin.command: cat /sys/kernel/mm/transparent_hugepage/enabled
Expand Down
1 change: 1 addition & 0 deletions roles/sap_hana_preconfigure/tasks/sapnote/2382421.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
- name: Construct the command for getting all current parameters of file '{{ __sap_hana_preconfigure_etc_sysctl_saphana_conf }}'
ansible.builtin.command: awk 'BEGIN{FS="="; printf ("sysctl ")}{printf ("%s ", $1)}' "{{ __sap_hana_preconfigure_etc_sysctl_saphana_conf }}"
register: __sap_hana_preconfigure_register_saphana_conf_sysctl_command
check_mode: false
changed_when: false

- name: Get all currently active values of the parameters of file '{{ __sap_hana_preconfigure_etc_sysctl_saphana_conf }}'
Expand Down