Skip to content

fix reboot in sap_general_preconfigure#892

Merged
berndfinger merged 1 commit into
sap-linuxlab:devfrom
SAPUCC:fix/notify_reboot_handler
Nov 26, 2024
Merged

fix reboot in sap_general_preconfigure#892
berndfinger merged 1 commit into
sap-linuxlab:devfrom
SAPUCC:fix/notify_reboot_handler

Conversation

@crysaki
Copy link
Copy Markdown
Contributor

@crysaki crysaki commented Nov 21, 2024

changed_when: false while notify the reboot handler will always cause to not call the handler, so I've changed to changed_when: true

@berndfinger berndfinger changed the title fix reboot in sap_generel_preconfigure fix reboot in sap_general_preconfigure Nov 22, 2024
@berndfinger berndfinger self-assigned this Nov 22, 2024
@berndfinger berndfinger self-requested a review November 22, 2024 20:27
Copy link
Copy Markdown
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berndfinger berndfinger merged commit fc1ecd9 into sap-linuxlab:dev Nov 26, 2024
@berndfinger
Copy link
Copy Markdown
Member

@crysaki Thanks for reporting this!

@berndfinger
Copy link
Copy Markdown
Member

... and also for suggesting the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants