-
Notifications
You must be signed in to change notification settings - Fork 64
sap_swpm: add functionality to set specific DDIC and SAP* passwords during new installation #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rob0d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "fix" in pull request #763 was incorrect, so restored the original functionality (related to system copies) and added the correct config in the jinja template.
|
To match 1.5.x updated style, and create future proof naming..... I would suggest and will test the below {% if sap_swpm_ddic_000_password | d('',true) | length > 0 %}
###################################################################
# BEGIN section credentials_install_ddic_000 #
# #
NW_CI_Instance_ABAP_Reports.needNewDDIC000Password = true
NW_CI_Instance_ABAP_Reports.ddic000Password = {{ sap_swpm_ddic_000_password }}
# #
# END section credentials_install_ddic_000 #
###################################################################
{% endif %}
{% if sap_swpm_sapstar_000_password | d('',true) | length > 0 %}
###################################################################
# BEGIN section credentials_install_sapstar_000 #
# #
NW_CI_Instance_ABAP_Reports.needNewSapStar000Password = true
NW_CI_Instance_ABAP_Reports.sapStar000Password = {{ sap_swpm_sapstar_000_password }}
# #
# END section credentials_install_sapstar_000 #
###################################################################
{% endif %}
{% if 'credentials_syscopy_ddic_000' in sap_swpm_inifile_sections_list %}
###################################################################
# BEGIN section credentials_syscopy_ddic_000 #
# #
NW_DDIC_Password.needDDICPasswords = true
NW_DDIC_Password.ddic000Password = {{ sap_swpm_ddic_000_password | default(sap_swpm_master_password) }}
#NW_DDIC_Password.ddic001Password =
# #
# END section credentials_syscopy_ddic_000 #
###################################################################
{% endif %} |
|
Sean, do you want me to do a commit as per the above or will you update it? |
|
@rob0d To preserve your commit / effort, it has to be done by yourself. Likely requires a |
Solves issue sap-linuxlab#879. Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Solves issue sap-linuxlab#883. Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
... for better readability Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
... in defaults/main.yml Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Due to the use of global variables in sap_swpm, there appears to be no simple way of giving priority to top level vars over the same variables defined in sap_swpm_templates_install_dictionary. We can also assume that if using sap_swpm_templates_install_dictionary, this is done on purpose and with the intention to use its members with priority over top level variables. Signed-off-by: Bernd Finger <[email protected]>
Note: This is WIP. Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
This file should only exist on the collection level. Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
... and for the presence of sap_swpm_virtual_hostname in case of HA installation types Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Also modify the fail_msg to not resolve sap_swpm_virtual_hostname Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Solves issue sap-linuxlab#885. Signed-off-by: Bernd Finger <[email protected]>
Solves issue sap-linuxlab#782. Signed-off-by: Bernd Finger <[email protected]>
Solves issue sap-linuxlab#689. Further changes in this commit: - Add the SAP note numbers and versions in a comment before the list of packages in the RedHat*.yml files in vars. - Add 'ansible_architecture' as a condition in the related installation task, so that there is no task failure when running on another architecture than 'x86_64'. - Also revert back to the default of 'false' for the role variable 'sap_netweaver_preconfigure_use_adobe_doc_services'. See commit 384f4d8, PR sap-linuxlab#876. Signed-off-by: Bernd Finger <[email protected]>
SAP HANA 2.0 SPS08 is built with GCC13, so we need to install compat-sap-c++-13. Solves sap-linuxlab#893. Signed-off-by: Bernd Finger <[email protected]>
Fix for issue #764 and replacement of pull request #763