sap_ha_pacemaker_cluster: GCP haproxy handling and new platform VIP dictionary#862
Merged
Merged
Conversation
ja9fuchs
approved these changes
Sep 11, 2024
Contributor
ja9fuchs
left a comment
There was a problem hiding this comment.
lgtm, adds flexibility to the VIP methods per platform and OS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
gcp_nlb_reserved_ip_haproxymethod is used. This is not necessary foripaddrmethod.__sap_ha_pacemaker_cluster_sap_extra_packages_dictdictionary in OS var files to accommodate override over default VIP method. This is similar dictionary implementation as done before for stonith, extra packages and others.Reason
haproxy is not documented method to be used on SUSE as per documentation from Google.