sap_install_media_detect: Allow disabling RAR handling#856
Merged
berndfinger merged 1 commit intoSep 4, 2024
Conversation
Fixes sap-linuxlab#855. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Member
Author
|
Note: This additional option should only be used when it is known that there are no RAR or self-extracting RAR/EXE files in the |
Member
Author
|
My tests with ap4s-scenarios |
ja9fuchs
approved these changes
Sep 4, 2024
Contributor
ja9fuchs
left a comment
ja9fuchs
left a comment
There was a problem hiding this comment.
lgtm and works well in a test on RHEL 9.4 with sap_install_media_detect_rar_handling: false. Before the fix and the parameter it failed due to the epel repo issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #855.