Skip to content

Conversation

@berndfinger
Copy link
Member

No description provided.

crysaki and others added 30 commits July 25, 2023 10:25
sap_storage_setup: improved idempotency
sap_ha_pacemaker_cluster: fix missing value in platform task conditional
sap_install_media_detect: Solve issue #429
sap_install_media_detect: Display all facts at the end of the role
... instead of 'destination', for consistency.
... instead of contains.
Also use regex patterns, and use only true/false for booleans in the
find tasks.
Solves issue #388
sap_install_media_detect: use 'patterns' for find
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoroughly tested, no regressions identified. Approved for merge

Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@berndfinger berndfinger removed the request for review from sean-freeman August 15, 2023 09:24
@berndfinger berndfinger merged commit 18df234 into main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants