-
Notifications
You must be signed in to change notification settings - Fork 64
collection: merge dev to main for release 1.3.1 #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no mapping defined
sap_storage_setup: improved idempotency
sap_ha_pacemaker_cluster: fix missing value in platform task conditional
…r complex if statements
… combination with grep -q
Solve issue 426
sap_install_media_detect: Solve issue #429
sap_install_media_detect: Display all facts at the end of the role
... instead of 'destination', for consistency.
Solve issue #428
... instead of contains. Also use regex patterns, and use only true/false for booleans in the find tasks. Solves issue #388
sap_install_media_detect: use 'patterns' for find
sap_hana_install: Fix issue #436
sap_ha_pacemaker_cluster: AWS improvements
sap_swpm: output improvements
collection: prepare for v1.3.1
sean-freeman
approved these changes
Aug 14, 2023
Member
sean-freeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoroughly tested, no regressions identified. Approved for merge
ja9fuchs
approved these changes
Aug 15, 2023
Contributor
ja9fuchs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.