sap_hana_install: simplified and more flexible SELinux and fapolicyd handling #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unify the definition of SELinux and fapolicyd directories - add an option to enable and start fapolicyd after the installation of SAP HANA (default is now not to enable and not to start it) Solves issue sap-linuxlab#1134. Signed-off-by: Bernd Finger <[email protected]>
Relates to sap-linuxlab#1134. Signed-off-by: Bernd Finger <[email protected]>
Relates to sap-linuxlab#1134. Signed-off-by: Bernd Finger <[email protected]>
Also rename a loop variable. Relates to #sap-linuxlab#1134. Signed-off-by: Bernd Finger <[email protected]>
Relates to sap-linuxlab#1134. Signed-off-by: Bernd Finger <[email protected]>
... to sap_hana_install_configure_fapolicy. Relates to sap-linuxlab#1134. Signed-off-by: Bernd Finger <[email protected]>
... to sap_hana_install_configure_selinux Relates to sap-linuxlab#1134. Signed-off-by: Bernd Finger <[email protected]>
- Ensure backward compatibility with selinux and fapolicyd variables - Fix typo in fapolicyd var names - Improve explanation section for selinux var in defaults/main.yml Signed-off-by: Bernd Finger <[email protected]>
Relates to sap-linuxlab#1134. Signed-off-by: Bernd Finger <[email protected]>
- Move variable preparation, including assertions, to separate task file - Set the default for starting fapolicyd to 'true' Relates to sap-linuxlab#1134. Signed-off-by: Bernd Finger <[email protected]>
It should be sufficient to display the local command to be executed on the managed node. Signed-off-by: Bernd Finger <[email protected]>
If sap_hana_install_modify_selinux_labels is defined in a playbook or inventory, use that one instead of sap_hana_install_configure_selinux (which is also defined in defaults/main.ylm). If sap_hana_install_use_fapolicyd is defined in a playbook or inventory, use that one instead of sap_hana_install_configure_fapolicyd (which is also defined in defaults/main.ylm). As a consequence, when using the new variables, the old ones should be removed from the playbook or inventory - otherwise, the new variables will be ignored. Relates to sap-linuxlab#1134. Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
marcelmamula
approved these changes
Dec 1, 2025
Contributor
marcelmamula
left a comment
marcelmamula
left a comment
There was a problem hiding this comment.
LGTM from code perspective, @ja9fuchs will do testing and review.
ja9fuchs
reviewed
Dec 2, 2025
ja9fuchs
reviewed
Dec 2, 2025
Relates to sap-linuxlab#1134. Signed-off-by: Bernd Finger <[email protected]>
ja9fuchs
approved these changes
Dec 3, 2025
Contributor
ja9fuchs
left a comment
ja9fuchs
left a comment
There was a problem hiding this comment.
LGTM and run a basic test on an existing instance.
berndfinger
deleted the
combine-selinux-and-fapolicyd-dir-definitions-02
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
SELinuxandfapolicyddirectoriesfapolicydafter the installation of SAP HANA (default is now not to enable and not to start it)Solves issue #1134.